Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restake rewards #1358

Merged
merged 10 commits into from
Aug 16, 2024
Merged

Restake rewards #1358

merged 10 commits into from
Aug 16, 2024

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Jul 17, 2024

Pull Request Summary

Added an optional feature to restake user rewards. Reward will be proportionally staked on dApp user is currently staking on.

There are two use cases

  • First one when staking to dApps. Go through staking wizard components. Restake modal is the last step and it will be shown in case you have rewards to claim.
  • Second one when claiming rewards

Short tutorial https://www.loom.com/share/b8bef5757c164140a3229187e11d214d

image

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

Copy link

github-actions bot commented Jul 17, 2024

Visit the preview URL for this PR (updated for commit 25023bd):

https://astar-apps--pr1358-feat-restake-rewards-6a1hbg9o.web.app

(expires Thu, 15 Aug 2024 08:18:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@bobo-k2 bobo-k2 marked this pull request as ready for review July 19, 2024 07:11
@impelcrypto
Copy link
Member

@bobo-k2 How can I open the modal?

@bobo-k2
Copy link
Contributor Author

bobo-k2 commented Jul 22, 2024

@bobo-k2 How can I open the modal?

I am sorry I didn't describe that. You need to go through staking wizard. This is the last step in case you have rewards to claim

@impelcrypto
Copy link
Member

@bobo-k2
Like this? Could you help share the record?
https://www.loom.com/share/c124d3eb022849938deb104093ed4be8

@bobo-k2
Copy link
Contributor Author

bobo-k2 commented Jul 24, 2024

@bobo-k2 Like this? Could you help share the record? https://www.loom.com/share/c124d3eb022849938deb104093ed4be8

Added recording to the PR desscription

@impelcrypto
Copy link
Member

@bobo-k2 Thanks, LGTM

Copy link
Member

@gtg7784 gtg7784 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobo-k2 bobo-k2 merged commit 99561ac into main Aug 16, 2024
9 checks passed
@bobo-k2 bobo-k2 deleted the feat/restake-rewards branch August 16, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants